Fix JDK http client propagation of non-sampled traces #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
tylerbenson
approved these changes
Jul 30, 2021
| // sleep to ensure no spans are emitted | ||
| Thread.sleep(1000); | ||
|
|
||
| assertThat(testing.traces()).isEmpty(); |
There was a problem hiding this comment.
How does this verify that the proper headers are being sent? Would you expect the server to generate a trace if it wasn't?
| if (Java8BytecodeBridge.currentSpan().isRecording()) { | ||
| headers = tracer().inject(headers); | ||
| } | ||
| headers = tracer().inject(headers); |
There was a problem hiding this comment.
Looks like I just happened to pick an unlucky client. ;-)
There was a problem hiding this comment.
or a lucky one, to find this bug 💯
|
closing and re-opening to re-trigger CLA check |
|
/easycla |
anuraaga
approved these changes
Jul 31, 2021
| assertThat(responseCode).isEqualTo(200); | ||
|
|
||
| // sleep to ensure no spans are emitted | ||
| Thread.sleep(1000); |
There was a problem hiding this comment.
1s seems too slow how about around 200? I think we get traces back in just a few ms most times.
iNikem
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And adds missing test coverage to
HttpClientTest